Issue 13526043: code review 13526043: go.tools/oracle: change notation for byte offsets to "-...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13526043: code review 13526043: go.tools/oracle: change notation for byte offsets to "-... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by adonovan

Modified:
10 years, 8 months ago

Reviewers:
crawshaw1

CC:
r, crawshaw1, golang-dev

Visibility:
Public.

Description

go.tools/oracle: change notation for byte offsets to "-pos=file.go:#123-#456" The previous notation (sans '#') now yields an error but is "reserved for future use", e.g. to denote line/column offsets. Will implement as needed.

Patch Set 1 #

Patch Set 2 : diff -r eb8b5b6f18de https://code.google.com/p/go.tools #

Patch Set 3 : diff -r eb8b5b6f18de https://code.google.com/p/go.tools #

Patch Set 4 : diff -r 0a0f18e14640 https://code.google.com/p/go.tools #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -25 lines)			Patch
M	cmd/oracle/main.go	View	1 2 3	3 chunks	+9 lines, -11 lines	0 comments	Download
M	cmd/oracle/oracle.el	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	cmd/oracle/oracle.vim	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	oracle/oracle.go	View	1 2 3	2 chunks	+17 lines, -10 lines	0 comments	Download
M	oracle/oracle_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello r@golang.org, crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 8 months ago (2013-09-04 14:05:12 UTC) #1

adonovan

10 years, 8 months ago (2013-09-04 18:35:26 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=072f1bafb7f0&repo=tools ***

go.tools/oracle: change notation for byte offsets to "-pos=file.go:#123-#456"

The previous notation (sans '#') now yields an error but is
"reserved for future use", e.g. to denote line/column offsets.
Will implement as needed.

R=r, crawshaw
CC=golang-dev
https://codereview.appspot.com/13526043

Expand All Messages | Collapse All Messages