Issue 13521044: code review 13521044: test: fix build (update for new error message)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13521044: code review 13521044: test: fix build (update for new error message) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
bradfitz

CC:
golang-dev

Visibility:
Public.

Description

test: fix build (update for new error message)

Patch Set 1 #

Patch Set 2 : diff -r 7b317abe8dd5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 88b14c51bd57 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	test/syntax/chan1.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-06 20:15:29 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=0c02c817d815 *** test: fix build (update for new error message) R=golang-dev CC=golang-dev ...

11 years, 6 months ago (2013-09-06 20:15:33 UTC) #2

bradfitz

11 years, 6 months ago (2013-09-06 20:24:35 UTC) #3

LGTM



On Fri, Sep 6, 2013 at 1:15 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> test: fix build (update for new error message)
>
> Please review this at
https://codereview.appspot.**com/13521044/<https://codereview.appspot.com/135...
>
> Affected files (+2, -2 lines):
>   M test/syntax/chan1.go
>
>
> Index: test/syntax/chan1.go
> ==============================**==============================**=======
> --- a/test/syntax/chan1.go
> +++ b/test/syntax/chan1.go
> @@ -10,8 +10,8 @@
>  var v int
>
>  func main() {
> -       if c <- v { // ERROR "send statement.*value.*select"
> +       if c <- v { // ERROR "used as value"
>         }
>  }
>
> -var _ = c <- v // ERROR "send statement.*value.*select"
> +var _ = c <- v // ERROR "used as value"
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

Expand All Messages | Collapse All Messages