code review 135170044: cmd/ld: diagnose Go calling C

cmd/ld: diagnose Go calling C

For example:
go build -ldflags -C cmd/go 2>&1 | awk '{print $NF}' | sort | uniq -c | sort -nr

[rsc, 2014-08-29 03:10:09]

Hello khr (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[josharian, 2014-08-29 17:09:40]

Code looks good.

Is the overloading of the dupok byte temporary? If not some comments would be
useful in the file format docs at the top of objfile.c and in debug/goobj.

[khr, 2014-08-29 20:43:10]

LGTM

[rsc, 2014-09-01 02:40:31]

On Fri, Aug 29, 2014 at 1:09 PM, <josharian@gmail.com> wrote:

> Code looks good.
>
> Is the overloading of the dupok byte temporary? If not some comments
> would be useful in the file format docs at the top of objfile.c and in
> debug/goobj.
>

There are no file format docs in debug/goobj that I could find.
I updated the docs in objfile.c to make both dupok and leaf flags, and I
moved the cfunc bit to the text-specific flags (where leaf is).

[rsc, 2014-09-01 02:49:19]

*** Submitted as https://code.google.com/p/go/source/detail?r=ff82d3107ab3 ***

cmd/ld: diagnose Go calling C

For example:
go build -ldflags -C cmd/go 2>&1 | awk '{print $NF}' | sort | uniq -c | sort -nr

LGTM=khr
R=khr, josharian
CC=golang-codereviews
https://codereview.appspot.com/135170044