Issue 13512053: code review 13512053: cmd/gc: allow x[i:j:k] (and x[:j:k]) into the release

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13512053: code review 13512053: cmd/gc: allow x[i:j:k] (and x[:j:k]) into the release (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: allow x[i:j:k] (and x[:j:k]) into the release

Patch Set 1 #

Patch Set 2 : diff -r 63f29041c1cf https://code.google.com/p/go/ #

Patch Set 3 : diff -r f29b1dbabddf https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+740 lines, -1362 lines)			Patch
M	src/cmd/gc/go.y	View	1 2	2 chunks	+0 lines, -9 lines	0 comments	Download
M	src/cmd/gc/y.tab.h	View	1 2	3 chunks	+21 lines, -25 lines	0 comments	Download
M	src/cmd/gc/y.tab.c	View	1 2	165 chunks	+719 lines, -1328 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-11 18:55:44 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=589f704e5b5c *** cmd/gc: allow x[i:j:k] (and x[:j:k]) into the release R=ken2 CC=golang-dev ...

11 years, 6 months ago (2013-09-11 18:55:48 UTC) #2

ken3

11 years, 6 months ago (2013-09-11 21:47:23 UTC) #3

Message was sent while issue was closed.

On 2013/09/11 18:55:48, rsc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=589f704e5b5c ***
> 
> cmd/gc: allow x[i:j:k] (and x[:j:k]) into the release
> 
> R=ken2
> CC=golang-dev
> https://codereview.appspot.com/13512053

lgtm

Expand All Messages | Collapse All Messages