Issue 135040043: code review 135040043: go-tour: store file contents in local storage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 135040043: code review 135040043: go-tour: store file contents in local storage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by francesc

Modified:
9 years, 8 months ago

Reviewers:
adg

CC:
adg, golang-codereviews

Visibility:
Public.

Description

go-tour: store file contents in local storage Added reset button and moved the syntax checkbox to the top of the editor. Fixes issue 179

Patch Set 1 #

Patch Set 2 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 3 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 4 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 5 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 6 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 7 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 8 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 9 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Patch Set 10 : diff -r 812a95352867b8da87e7f5c125f586cdc06c97c3 https://code.google.com/p/go-tour #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -6 lines)			Patch
M	static/css/app.css	View	1 2 3 4 5	1 chunk	+3 lines, -0 lines	0 comments	Download
M	static/js/controllers.js	View	1 2 3 4 5 6 7 8	2 chunks	+16 lines, -3 lines	0 comments	Download
M	static/js/services.js	View	1 2 3 4 5 6 7	2 chunks	+14 lines, -2 lines	0 comments	Download
M	static/partials/editor.html	View	1 2 3 4 5	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

9 years, 8 months ago (2014-08-28 01:57:58 UTC) #1

adg

There needs to be a mechanism to reset the content. Is there?

9 years, 8 months ago (2014-08-28 03:02:14 UTC) #2

adg

On 28 August 2014 11:57, <campoy@golang.org> wrote: > Fixes 179 Should be "Fixes issue 179."

9 years, 8 months ago (2014-08-28 03:02:14 UTC) #3

francesc

On 2014/08/28 03:02:14, adg wrote: > On 28 August 2014 11:57, <mailto:campoy@golang.org> wrote: > > ...

9 years, 8 months ago (2014-08-28 03:53:36 UTC) #4

francesc

9 years, 8 months ago (2014-08-28 05:33:12 UTC) #6

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=380970f2c8c6
***

go-tour: store file contents in local storage

Added reset button and moved the syntax checkbox to the top of the editor.

Fixes issue 179

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/135040043

Expand All Messages | Collapse All Messages