Issue 13498046: code review 13498046: cmd/cgo: don't let #cgo directives mess up line numbering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13498046: code review 13498046: cmd/cgo: don't let #cgo directives mess up line numbering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by iant

Modified:
10 years, 7 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/cgo: don't let #cgo directives mess up line numbering Fixes issue 5272.

Patch Set 1 #

Patch Set 2 : diff -r 6adf94d423d6 https://code.google.com/p/go #

Patch Set 3 : diff -r 3ec3ff3de654 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
A	misc/cgo/errors/err1.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
A	misc/cgo/errors/test.bash	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/run.bash	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2013-09-04 00:44:23 UTC) #1

iant

10 years, 7 months ago (2013-09-04 04:15:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=008f2a022717 ***

cmd/cgo: don't let #cgo directives mess up line numbering

Fixes issue 5272.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13498046

Expand All Messages | Collapse All Messages