code review 134940044: cmd/gc: fix undefined behaviour warnings in mparith3.c

cmd/gc: fix undefined behaviour warnings in mparith3.c

Update issue 8527

Fixes two warnings:

src/cmd/gc/mparith3.c:255:10: runtime error: shift exponent 52 is too large for 32-bit type 'int'
src/cmd/gc/mparith3.c:254:14: runtime error: shift exponent 52 is too large for 32-bit type 'int'

[dave_cheney.net, 2014-08-27 02:33:02]

Hello r@golang.org, dvyukov@google.com (cc:
golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2014-08-27 05:04:55]

LGTM

[dave_cheney.net, 2014-08-27 05:26:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=601ad8b62553 ***

cmd/gc: fix undefined behaviour warnings in mparith3.c

Update issue 8527

Fixes two warnings:

src/cmd/gc/mparith3.c:255:10: runtime error: shift exponent 52 is too large for
32-bit type 'int'
src/cmd/gc/mparith3.c:254:14: runtime error: shift exponent 52 is too large for
32-bit type 'int'

LGTM=rsc
R=r, dvyukov, rsc
CC=golang-codereviews
https://codereview.appspot.com/134940044

[gobot, 2014-08-27 18:12:37]

This CL appears to have broken the nacl-386 builder.
See http://build.golang.org/log/745ce714768e97d94acf2a0fc1b8938c466083a4

[bradfitz, 2014-08-27 18:51:24]

Nope. That was my misconfiguration.



On Wed, Aug 27, 2014 at 11:12 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the nacl-386 builder.
> See http://build.golang.org/log/745ce714768e97d94acf2a0fc1b8938c466083a4
>
>
> https://codereview.appspot.com/134940044/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>