code review 13462046: cmd/go: fix go test using package main_test

cmd/go: fix go test using package main_test

A package main binary (that is, a command) being installed
does not mean we can skip the build of the package archive
during a test.

Fixes issue 3417.

[rsc, 2013-09-10 17:16:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-09-10 17:19:35]

LGTM
 On Sep 10, 2013 10:16 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: fix go test using package main_test
>
> A package main binary (that is, a command) being installed
> does not mean we can skip the build of the package archive
> during a test.
>
> Fixes issue 3417.
>
> Please review this at
https://codereview.appspot.**com/13462046/<https://codereview.appspot.com/134...
>
> Affected files (+36, -1 lines):
>   M src/cmd/go/test.bash
>   M src/cmd/go/test.go
>   A src/cmd/go/testdata/src/main_**test/m.go
>   A src/cmd/go/testdata/src/main_**test/m_test.go
>
>
> Index: src/cmd/go/test.bash
> ==============================**==============================**=======
> --- a/src/cmd/go/test.bash
> +++ b/src/cmd/go/test.bash
> @@ -138,6 +138,27 @@
>         ok=false
>  fi
>
> +TEST package main_test imports archive not binary
> +export GOBIN=$(pwd)/testdata/bin
> +mkdir -p $GOBIN
> +export GOPATH=$(pwd)/testdata
> +touch ./testdata/src/main_test/m.go
> +if ! ./testgo test main_test; then
> +       echo "go test main_test failed without install"
> +       ok=false
> +elif ! ./testgo install main_test; then
> +       echo "go test main_test failed"
> +       ok=false
> +elif [ "$(./testgo list -f '{{.Stale}}' main_test)" != false ]; then
> +       echo "after go install, main listed as stale"
> +       ok=false
> +elif ! ./testgo test main_test; then
> +       echo "go test main_test failed after install"
> +       ok=false
> +fi
> +rm -rf $GOBIN
> +unset GOBIN
> +
>  # And with $GOBIN set, binaries get installed to $GOBIN.
>  TEST install into GOBIN
>  if ! GOBIN=$(pwd)/testdata/bin1 GOPATH=$(pwd)/testdata ./testgo install
> go-cmd-test; then
> Index: src/cmd/go/test.go
> ==============================**==============================**=======
> --- a/src/cmd/go/test.go
> +++ b/src/cmd/go/test.go
> @@ -591,7 +591,7 @@
>         localCover := testCover && testCoverPaths == nil
>
>         // Test package.
> -       if len(p.TestGoFiles) > 0 || localCover {
> +       if len(p.TestGoFiles) > 0 || localCover || p.Name == "main" {
>                 ptest = new(Package)
>                 *ptest = *p
>                 ptest.GoFiles = nil
> Index: src/cmd/go/testdata/src/main_**test/m.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/cmd/go/testdata/src/**main_test/m.go
> @@ -0,0 +1,4 @@
> +package main
> +
> +func F()    {}
> +func main() {}
> Index: src/cmd/go/testdata/src/main_**test/m_test.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/cmd/go/testdata/src/**main_test/m_test.go
> @@ -0,0 +1,10 @@
> +package main_test
> +
> +import (
> +       . "main_test"
> +       "testing"
> +)
> +
> +func Test1(t *testing.T) {
> +       F()
> +}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-10 18:43:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=3c9e361c43ab ***

cmd/go: fix go test using package main_test

A package main binary (that is, a command) being installed
does not mean we can skip the build of the package archive
during a test.

Fixes issue 3417.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13462046