Issue 13441049: code review 13441049: go-tour/gotour: fix flag handling

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13441049: code review 13441049: go-tour/gotour: fix flag handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by r

Modified:
10 years, 8 months ago

Reviewers:
adg

CC:
adg, golang-dev

Visibility:
Public.

Description

go-tour/gotour: fix flag handling - change the flag name to "article" - give it the correct default (it had none, and then was programatically defaulted) - try the name, then the name in the root (before, only the default was looked for in the root)

Patch Set 1 #

Patch Set 2 : diff -r fb31a7df7b60 https://code.google.com/p/go-tour #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	gotour/local.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	gotour/tour.go	View		2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 8 months ago (2013-09-10 01:42:09 UTC) #1

10 years, 8 months ago (2013-09-10 01:50:29 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=c81778ad943c
***

go-tour/gotour: fix flag handling
- change the flag name to "article"
- give it the correct default
        (it had none, and then was programatically defaulted)
- try the name, then the name in the root
        (before, only the default was looked for in the root)

R=adg
CC=golang-dev
https://codereview.appspot.com/13441049

Expand All Messages | Collapse All Messages