code review 13431044: cmd/go: show FAIL for errors during test setup

cmd/go: show FAIL for errors during test setup

For example, if an x_test.go file contains a syntax error,
b.test fails with an error message. But it wasn't printing
the same FAIL line that a build failure later would print.
This makes all the test failures that happen (once we
decide to start running tests) consistently say FAIL.

Fixes issue 4701.

[rsc, 2013-09-10 17:34:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-09-10 17:57:25]

LGTM



On Tue, Sep 10, 2013 at 10:34 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: show FAIL for errors during test setup
>
> For example, if an x_test.go file contains a syntax error,
> b.test fails with an error message. But it wasn't printing
> the same FAIL line that a build failure later would print.
> This makes all the test failures that happen (once we
> decide to start running tests) consistently say FAIL.
>
> Fixes issue 4701.
>
> Please review this at
https://codereview.appspot.**com/13431044/<https://codereview.appspot.com/134...
>
> Affected files (+22, -2 lines):
>   M src/cmd/go/test.bash
>   M src/cmd/go/test.go
>   A src/cmd/go/testdata/src/**syntaxerror/x.go
>   A src/cmd/go/testdata/src/**syntaxerror/x_test.go
>
>
> Index: src/cmd/go/test.bash
> ==============================**==============================**=======
> --- a/src/cmd/go/test.bash
> +++ b/src/cmd/go/test.bash
> @@ -104,6 +104,19 @@
>  testlocal "$bad" 'with bad characters in path'
>  rm -rf "testdata/$bad"
>
> +TEST error message for syntax error in test go file says FAIL
> +export GOPATH=$(pwd)/testdata
> +if ./testgo test syntaxerror 2>testdata/err; then
> +       echo 'go test syntaxerror succeeded'
> +       ok=false
> +elif ! grep FAIL testdata/err >/dev/null; then
> +       echo 'go test did not say FAIL:'
> +       cat testdata/err
> +       ok=false
> +fi
> +rm -f ./testdata/err
> +unset GOPATH
> +
>  # Test tests with relative imports.
>  TEST relative imports '(go test)'
>  if ! ./testgo test ./testdata/testimport; then
> Index: src/cmd/go/test.go
> ==============================**==============================**=======
> --- a/src/cmd/go/test.go
> +++ b/src/cmd/go/test.go
> @@ -423,10 +423,12 @@
>                         if strings.HasPrefix(str, "\n") {
>                                 str = str[1:]
>                         }
> +                       failed := fmt.Sprintf("FAIL\t%s [setup failed]\n",
> p.ImportPath)
> +
>                         if p.ImportPath != "" {
> -                               errorf("# %s\n%s", p.ImportPath, str)
> +                               errorf("# %s\n%s\n%s", p.ImportPath, str,
> failed)
>                         } else {
> -                               errorf("%s", str)
> +                               errorf("%s\n%s", str, failed)
>                         }
>                         continue
>                 }
> Index: src/cmd/go/testdata/src/**syntaxerror/x.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/cmd/go/testdata/src/**syntaxerror/x.go
> @@ -0,0 +1,1 @@
> +package p
> Index: src/cmd/go/testdata/src/**syntaxerror/x_test.go
> ==============================**==============================**=======
> new file mode 100644
> --- /dev/null
> +++ b/src/cmd/go/testdata/src/**syntaxerror/x_test.go
> @@ -0,0 +1,4 @@
> +package p
> +
> +func f() (x.y, z int) {
> +}
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-10 18:44:00]

*** Submitted as https://code.google.com/p/go/source/detail?r=143e5a765bb1 ***

cmd/go: show FAIL for errors during test setup

For example, if an x_test.go file contains a syntax error,
b.test fails with an error message. But it wasn't printing
the same FAIL line that a build failure later would print.
This makes all the test failures that happen (once we
decide to start running tests) consistently say FAIL.

Fixes issue 4701.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13431044