code review 13427045: go/doc: restore handling of multi-paragraph BUG comments

go/doc: restore handling of multi-paragraph BUG comments

It was lost when the generic "Notes" support went in.

Had to change the test setup, because it precluded even
being able test multi-line comments, much less multi-paragraph
comments.

Now 'godoc sync/atomic' works correctly again.

Fixes issue 6135.

[rsc, 2013-09-09 23:56:47]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-09-10 18:03:43]

LGTM

Chunk mismatches or I'd reply inline, but: slight preference towards
defining an int type for clean flags, instead of just "flags int".
 Unexported, though, so care less.




On Mon, Sep 9, 2013 at 4:56 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/doc: restore handling of multi-paragraph BUG comments
>
> It was lost when the generic "Notes" support went in.
>
> Had to change the test setup, because it precluded even
> being able test multi-line comments, much less multi-paragraph
> comments.
>
> Now 'godoc sync/atomic' works correctly again.
>
> Fixes issue 6135.
>
> Please review this at
https://codereview.appspot.**com/13427045/<https://codereview.appspot.com/134...
>
> Affected files (+186, -45 lines):
>   src/pkg/go/doc/doc_test.go
>   src/pkg/go/doc/reader.go
>   src/pkg/go/doc/synopsis.go
>   src/pkg/go/doc/testdata/a.0.**golden
>   src/pkg/go/doc/testdata/a.1.**golden
>   src/pkg/go/doc/testdata/a.2.**golden
>   src/pkg/go/doc/testdata/**bugpara.0.golden
>   src/pkg/go/doc/testdata/**bugpara.1.golden
>   src/pkg/go/doc/testdata/**bugpara.2.golden
>   src/pkg/go/doc/testdata/**bugpara.go
>   src/pkg/go/doc/testdata/**template.txt
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-10 18:40:30]

yeah, if it were exported i definitely would.

[rsc, 2013-09-10 18:41:23]

*** Submitted as https://code.google.com/p/go/source/detail?r=0b312b2f362b ***

go/doc: restore handling of multi-paragraph BUG comments

It was lost when the generic "Notes" support went in.

Had to change the test setup, because it precluded even
being able test multi-line comments, much less multi-paragraph
comments.

Now 'godoc sync/atomic' works correctly again.

Fixes issue 6135.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13427045