Issue 133980043: code review 133980043: runtime: fix windows signal handlers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 133980043: code review 133980043: runtime: fix windows signal handlers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
gobot, brainman, minux

CC:
golang-codereviews

Visibility:
Public.

Description

runtime: fix windows signal handlers Windows needs the return result in AX, but runtime.sighandler no longer stores it in AX. Load it back during the assembly trampoline.

Patch Set 1 #

Patch Set 2 : diff -r 05c3fee13eb3052c646ccfd389e3629e5cb12b7f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 07a722aece2db54bb4cccc58350b8657afbcdc35 https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	src/pkg/runtime/sys_windows_386.s	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
	M	src/pkg/runtime/sys_windows_amd64.s	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello brainman (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2014-08-27 18:43:04 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=28b7a2b36ff7 *** runtime: fix windows signal handlers Windows needs the return result ...

10 years, 6 months ago (2014-08-27 18:43:09 UTC) #2

gobot

This CL appears to have broken the freebsd-amd64-race builder. See http://build.golang.org/log/b0156d18564640d5ab609f937c5aff0bbb2faf70

10 years, 6 months ago (2014-08-27 20:51:54 UTC) #3

Message was sent while issue was closed.

LGTM

Alex

Expand All Messages | Collapse All Messages