Descriptionruntime: adjust errorCString definition to avoid allocation
The low-level implementation of divide on ARM assumes that
it can panic with an error created by newErrorCString without
allocating. If we make interface data words require pointer values,
the current definition would require an allocation when stored
in an interface. Changing the definition to use unsafe.Pointer
instead of uintptr avoids the allocation. This change is okay
because the field really is a pointer (to a C string in rodata).
Update issue 8405.
This should make CL 133830043 safe to try again.
Patch Set 1 #Patch Set 2 : diff -r e3775b98a6638ee3c69763f615a3eea4c61e6485 https://code.google.com/p/go/ #Patch Set 3 : diff -r e3775b98a6638ee3c69763f615a3eea4c61e6485 https://code.google.com/p/go/ #Patch Set 4 : diff -r e3775b98a6638ee3c69763f615a3eea4c61e6485 https://code.google.com/p/go/ #MessagesTotal messages: 8
|