Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(305)

Issue 13368057: code review 13368057: cmd/gc: cleanup SWITCH nodes after walk. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by remyoudompheng
Modified:
10 years, 6 months ago
Reviewers:
r, dvyukov
CC:
golang-dev, dvyukov, r
Visibility:
Public.

Description

cmd/gc: cleanup SWITCH nodes after walk. Keeping pointers from the pre-walk phase confuses the race detection instrumentation. Fixes issue 6418.

Patch Set 1 #

Patch Set 2 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 5b367120d592 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/cmd/gc/swt.c View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/race/testdata/mop_test.go View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2013-09-18 05:41:31 UTC) #1
dvyukov
LGTM, but please wait for somebody else to sign off as well probably racewalk should ...
10 years, 6 months ago (2013-09-18 05:54:01 UTC) #2
remyoudompheng
On 2013/09/18 05:54:01, dvyukov wrote: > LGTM, but please wait for somebody else to sign ...
10 years, 6 months ago (2013-09-19 05:55:46 UTC) #3
r
LGTM https://codereview.appspot.com/13368057/diff/5001/src/cmd/gc/swt.c File src/cmd/gc/swt.c (right): https://codereview.appspot.com/13368057/diff/5001/src/cmd/gc/swt.c#newcode823 src/cmd/gc/swt.c:823: // Discard old AST parts without a meaning ...
10 years, 6 months ago (2013-09-19 05:59:04 UTC) #4
remyoudompheng
10 years, 6 months ago (2013-09-19 07:23:10 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=a5f808750c7d ***

cmd/gc: cleanup SWITCH nodes after walk.

Keeping pointers from the pre-walk phase confuses
the race detection instrumentation.

Fixes issue 6418.

R=golang-dev, dvyukov, r
CC=golang-dev
https://codereview.appspot.com/13368057

https://codereview.appspot.com/13368057/diff/5001/src/cmd/gc/swt.c
File src/cmd/gc/swt.c (right):

https://codereview.appspot.com/13368057/diff/5001/src/cmd/gc/swt.c#newcode823
src/cmd/gc/swt.c:823: // Discard old AST parts without a meaning after walk.
On 2013/09/19 05:59:04, r wrote:
> // Discard old AST elements after a walk. They can confuse racewealk.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b