Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(995)

Issue 13367049: code review 13367049: go-tour: move programs and article file into new conten... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by r
Modified:
10 years, 8 months ago
Reviewers:
adg
CC:
adg, golang-dev
Visibility:
Public.

Description

go-tour: move programs and article file into new content subidirectory Also put the programs into a subdirectory of prog, prog/tour. This layout will keep things tidier as we add new tours. At least for now, the images stay where they are because they are served directly by the web server from the directory named static in the root.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M content/prog/tour/advanced-exercise-complex-cube-roots.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/basic-types.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/buffered-channels.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/channels.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/constants.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/default-selection.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/errors.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-equivalent-binary-trees.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-errors.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-fibonacci-closure.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-http-handlers.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-images.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-loops-and-functions.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-maps.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-rot-reader.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-slices.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exercise-web-crawler.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/exported-names.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/for.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/for-continued.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/for-is-gos-while.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/forever.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/function-closures.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/function-values.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/functions.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/functions-continued.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/goroutines.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/hello.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/if.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/if-and-else.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/if-with-a-short-statement.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/images.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/imports.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/interfaces.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/interfaces-are-satisfied-implicitly.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/making-slices.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/map-literals.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/map-literals-continued.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/maps.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/methods.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/methods-continued.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/methods-with-pointer-receivers.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/multiple-results.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/mutating-maps.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/named-results.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/nil-slices.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/numeric-constants.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/packages.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/pointers.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/range.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/range-and-close.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/range-continued.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/sandbox.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/select.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/short-variable-declarations.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/slices.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/slicing-slices.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/struct-fields.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/struct-literals.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/structs.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/switch.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/switch-evaluation-order.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/switch-with-no-condition.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/the-new-function.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/variables.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/variables-with-initializers.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/prog/tour/web-servers.go View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/tour.article View 56 chunks +66 lines, -66 lines 0 comments Download
M gotour/local.go View 1 chunk +6 lines, -1 line 0 comments Download
M gotour/tour.go View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
r
Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour
10 years, 8 months ago (2013-09-10 03:44:02 UTC) #1
adg
LGTM
10 years, 8 months ago (2013-09-10 03:45:37 UTC) #2
adg
10 years, 8 months ago (2013-09-10 03:46:25 UTC) #3
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=701b21164db6
***

go-tour: move programs and article file into new content subidirectory
Also put the programs into a subdirectory of prog, prog/tour.
This layout will keep things tidier as we add new tours.

At least for now, the images stay where they are because they are served
directly by the web server from the directory named static in the root.

R=adg
CC=golang-dev
https://codereview.appspot.com/13367049

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b