Issue 13366050: code review 13366050: cmd/go: report correct directory for 'no version control'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13366050: code review 13366050: cmd/go: report correct directory for 'no version control' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-dev, minux1

Visibility:
Public.

Description

cmd/go: report correct directory for 'no version control' The scan starts at the directory we care about and works backward to the GOPATH root. The error should say the original directory name, not the name of the GOPATH root. Fixes issue 6175.

Patch Set 1 #

Patch Set 2 : diff -r 143e5a765bb1 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ecc9ab36456e https://code.google.com/p/go/ #

Patch Set 4 : diff -r ecc9ab36456e https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	src/cmd/go/test.bash	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/cmd/go/vcs.go	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-10 19:02:27 UTC) #1

rsc

11 years, 6 months ago (2013-09-10 19:28:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=22365bd87858 ***

cmd/go: report correct directory for 'no version control'

The scan starts at the directory we care about and works
backward to the GOPATH root. The error should say the
original directory name, not the name of the GOPATH root.

Fixes issue 6175.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/13366050

Expand All Messages | Collapse All Messages