Issue 13361050: code review 13361050: go-tour: don't use a pointer to a map in web crawl exercise

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13361050: code review 13361050: go-tour: don't use a pointer to a map in web crawl exercise (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by r

Modified:
10 years, 8 months ago

Reviewers:
dsymonds

CC:
adg, dsymonds, golang-dev

Visibility:
Public.

Description

go-tour: don't use a pointer to a map in web crawl exercise It's unnecessary and misleading. Fixes issue 6322.

Patch Set 1 #

Patch Set 2 : diff -r 8557a1fcb4e3 https://code.google.com/p/go-tour #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	content/prog/tour/exercise-web-crawler.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 8 months ago (2013-09-13 06:13:55 UTC) #1

10 years, 8 months ago (2013-09-13 06:51:42 UTC) #3

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=32f4320f7ff4
***

go-tour: don't use a pointer to a map in web crawl exercise
It's unnecessary and misleading.
Fixes issue 6322.

R=adg, dsymonds
CC=golang-dev
https://codereview.appspot.com/13361050

Expand All Messages | Collapse All Messages