code review 133530043: text/template: 0xef is an integer, not a floating-point...

text/template: 0xef is an integer, not a floating-point value.
The discriminator in the execution engine was stupid.
Add a test to the parse package too. The problem wasn't there
but the particular case ('e' in a hex integer) was not covered.

Fixes issue 8622.

[r, 2014-09-03 21:32:02]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[ruiu, 2014-09-03 21:40:28]

https://codereview.appspot.com/133530043/diff/1/src/pkg/text/template/exec.go
File src/pkg/text/template/exec.go (right):

https://codereview.appspot.com/133530043/diff/1/src/pkg/text/template/exec.go...
src/pkg/text/template/exec.go:396: case constant.IsFloat &&
!strings.HasPrefix(constant.Text, "0x") && strings.IndexAny(constant.Text,
".eE") >= 0:
Is 0XEF also an integer?

[r, 2014-09-03 22:20:42]

Hello golang-codereviews@googlegroups.com, ruiu@google.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[r, 2014-09-03 22:20:47]

You'd think I'd know by now.

[ruiu, 2014-09-03 22:32:48]

LGTM

[r, 2014-09-03 22:57:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=3e59550be70b ***

text/template: 0xef is an integer, not a floating-point value.
The discriminator in the execution engine was stupid.
Add a test to the parse package too. The problem wasn't there
but the particular case ('e' in a hex integer) was not covered.

Fixes issue 8622.

LGTM=ruiu
R=golang-codereviews, ruiu
CC=golang-codereviews
https://codereview.appspot.com/133530043

[gobot, 2014-09-03 22:58:41]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/beea41b533bc5e7afaebd95b1d79b78f4d0872c0