Issue 13352046: code review 13352046: cmd/go: build SWIG shared libraries in work directory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13352046: code review 13352046: cmd/go: build SWIG shared libraries in work directory (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by iant

Modified:
10 years, 8 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: build SWIG shared libraries in work directory Remove test of whether SWIG shared library is older than sources--should be covered by test of package file anyhow. Fixes issue 5739.

Patch Set 1 #

Patch Set 2 : diff -r 2d673b7f9c9e https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -18 lines)			Patch
	M	src/cmd/go/build.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/cmd/go/pkg.go	View	1	1 chunk	+1 line, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2013-09-09 23:47:45 UTC) #1

iant

10 years, 8 months ago (2013-09-10 18:00:30 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=27d7cbbd495a ***

cmd/go: build SWIG shared libraries in work directory

Remove test of whether SWIG shared library is older than
sources--should be covered by test of package file anyhow.

Fixes issue 5739.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13352046

Expand All Messages | Collapse All Messages