Issue 13345048: code review 13345048: cmd/cgo: allow C.malloc(0) always

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13345048: code review 13345048: cmd/cgo: allow C.malloc(0) always (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
iant

CC:
golang-dev, iant, minux1

Visibility:
Public.

Description

cmd/cgo: allow C.malloc(0) always Because we can, and because it otherwise might crash the program if we think we're out of memory. Fixes issue 6390.

Patch Set 2 : diff -r 589bcd9dd528 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r a6fc26ebfd61 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
M	misc/cgo/test/cgo_test.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/cgo/out.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_util.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-16 15:13:22 UTC) #1

minux1

https://codereview.appspot.com/13345048/diff/2001/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): https://codereview.appspot.com/13345048/diff/2001/src/cmd/cgo/out.go#newcode1229 src/cmd/cgo/out.go:1229: p = malloc(1); i wonder why translate malloc(0) to ...

11 years, 6 months ago (2013-09-16 15:26:52 UTC) #3

rsc

> https://codereview.appspot.com/13345048/diff/2001/src/cmd/cgo/out.go#newcode1229 > src/cmd/cgo/out.go:1229: p = malloc(1); > i wonder why translate malloc(0) to malloc(1)? ...

11 years, 6 months ago (2013-09-16 17:46:24 UTC) #4

rsc

11 years, 6 months ago (2013-09-16 18:04:58 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=c2779374f662 ***

cmd/cgo: allow C.malloc(0) always

Because we can, and because it otherwise might crash
the program if we think we're out of memory.

Fixes issue 6390.

R=golang-dev, iant, minux.ma
CC=golang-dev
https://codereview.appspot.com/13345048

Expand All Messages | Collapse All Messages