Issue 13321048: code review 13321048: runtime/pprof: run TestGoroutineSwitch for longer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13321048: code review 13321048: runtime/pprof: run TestGoroutineSwitch for longer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by brainman

Modified:
10 years, 7 months ago

Reviewers:
minux1, r, rsc

CC:
golang-dev, minux1, r

Visibility:
Public.

Description

runtime/pprof: run TestGoroutineSwitch for longer Short test now takes about 0.5 second here. Fixes issue 6417. The failure was also seen on our builders.

Patch Set 1 #

Patch Set 2 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 84975e4930dd https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r b4623c079d39 https://go.googlecode.com/hg/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/runtime/pprof/pprof_test.go	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 7 months ago (2013-09-18 06:15:00 UTC) #1

brainman

On 2013/09/21 23:12:15, minux wrote: > LGTM. No waiting for Russ? Alex

10 years, 7 months ago (2013-09-21 23:13:44 UTC) #3

minux1

so let's wait for russ or any other member of the team to sign off. ...

10 years, 7 months ago (2013-09-21 23:25:33 UTC) #4

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=9567c5da6e25 *** runtime/pprof: run TestGoroutineSwitch for longer Short test now takes about ...

10 years, 7 months ago (2013-09-22 07:31:16 UTC) #6

rsc

10 years, 7 months ago (2013-09-23 19:46:29 UTC) #7

I do disagree. :-)

The profile is fine, it's just got a single sample stack. The bound 13 is
too large. It should be 5 for the head, 3 for the tail, and 2 for the
header on the first profile entry, so 10, not 13.

Expand All Messages | Collapse All Messages