Issue 13314048: code review 13314048: cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13314048: code review 13314048: cmd/ld: fix "_image_base__ not defined" problem for cmd/8l. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by minux1

Modified:
10 years, 7 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/ld: fix "_image_base__ not defined" problem for cmd/8l. Fixes issue 6431. Change suggested by kin.wilson.za.

Patch Set 1 #

Patch Set 2 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Patch Set 3 : diff -r 00ff0c821b3f https://code.google.com/p/go #

Patch Set 4 : diff -r b9d8e297919c https://code.google.com/p/go #

Patch Set 5 : diff -r 06c20cdf7bc0 https://code.google.com/p/go #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/cmd/ld/pe.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 7 months ago (2013-09-23 04:14:28 UTC) #1

minux1

10 years, 7 months ago (2013-09-23 17:08:09 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=46b68d2aa38e ***

cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.
Fixes issue 6431.

Change suggested by kin.wilson.za.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/13314048

Expand All Messages | Collapse All Messages