Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(530)

Issue 133120045: code review 133120045: runtime: fix arm5 softfloat build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dave
Modified:
10 years, 6 months ago
Reviewers:
rsc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

runtime: fix arm5 softfloat build runtime._sfloat2 now returns the lr value on the stack, not R0. Credit to Russ Cox for the fix.

Patch Set 1 #

Patch Set 2 : code review 133120045: runtime: fix arm5 softfloat build #

Patch Set 3 : diff -r 14ab6d0208b61ae3aa52a24c89905571e8973d4e https://code.google.com/p/go #

Patch Set 4 : diff -r dbef39a08d10201cf67b38c16d223fdbc54ab385 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/pkg/runtime/vlop_arm.s View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 6 months ago (2014-08-28 01:35:35 UTC) #1
rsc
LGTM
10 years, 6 months ago (2014-08-28 02:06:26 UTC) #2
dave_cheney.net
Thanks. I've tested this on an arm5 and an arm7 with GOARM=5 and it passes. ...
10 years, 6 months ago (2014-08-28 02:08:33 UTC) #3
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=5d86455c5499 *** runtime: fix arm5 softfloat build runtime._sfloat2 now returns the lr ...
10 years, 6 months ago (2014-08-28 02:33:04 UTC) #4
rsc
10 years, 6 months ago (2014-08-28 02:36:05 UTC) #5
you might as well submit it now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b