code review 132680043: cmd/dist: remove goc2c

cmd/dist: remove goc2c

After the three pending CLs listed below, there will be no more .goc files.

134580043	runtime: move stubs.goc code into runtime.c
133670043	runtime: fix windows syscalls for copying stacks
141180043	runtime: eliminate Go -> C -> block paths for Solaris

[rsc, 2014-09-06 19:11:56]

Hello golang-codereviews@googlegroups.com (cc: iant, r),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-09-06 19:47:05]

LGTM

yay!



On Sat, Sep 6, 2014 at 12:11 PM, <rsc@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com (cc: iant, r),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/dist: remove goc2c
>
> After the three pending CLs listed below, there will be no more .goc
> files.
>
> 134580043       runtime: move stubs.goc code into runtime.c
> 133670043       runtime: fix windows syscalls for copying stacks
> 141180043       runtime: eliminate Go -> C -> block paths for Solaris
>
> Please review this at https://codereview.appspot.com/132680043/
>
> Affected files (+0, -860 lines):
>   M src/cmd/dist/a.h
>   M src/cmd/dist/build.c
>   R src/cmd/dist/goc2c.c
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[dave_cheney.net, 2014-09-06 23:55:47]

Outstanding

On Sun, Sep 7, 2014 at 5:47 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM
>
> yay!
>
>
>
> On Sat, Sep 6, 2014 at 12:11 PM, <rsc@golang.org> wrote:
>>
>> Reviewers: golang-codereviews,
>>
>> Message:
>> Hello golang-codereviews@googlegroups.com (cc: iant, r),
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> cmd/dist: remove goc2c
>>
>> After the three pending CLs listed below, there will be no more .goc
>> files.
>>
>> 134580043       runtime: move stubs.goc code into runtime.c
>> 133670043       runtime: fix windows syscalls for copying stacks
>> 141180043       runtime: eliminate Go -> C -> block paths for Solaris
>>
>> Please review this at https://codereview.appspot.com/132680043/
>>
>> Affected files (+0, -860 lines):
>>   M src/cmd/dist/a.h
>>   M src/cmd/dist/build.c
>>   R src/cmd/dist/goc2c.c
>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[rsc, 2014-09-07 11:23:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=0d66cda3ac1f ***

cmd/dist: remove goc2c

After the three pending CLs listed below, there will be no more .goc files.

134580043	runtime: move stubs.goc code into runtime.c
133670043	runtime: fix windows syscalls for copying stacks
141180043	runtime: eliminate Go -> C -> block paths for Solaris

LGTM=bradfitz
R=golang-codereviews, bradfitz, dave
CC=golang-codereviews, iant, r
https://codereview.appspot.com/132680043

[gobot, 2014-09-07 11:25:28]

This CL appears to have broken the windows-amd64-perf builder.
See http://build.golang.org/log/1f4cc1f516d763e07226878074e116e07fbb2448