Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2577)

Issue 13263054: code review 13263054: go.talks/present: use present and socket packages from ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by adg
Modified:
10 years, 7 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

go.talks/present: use present and socket packages from go.tools

Patch Set 1 #

Patch Set 2 : diff -r 3d856d9a5ac3 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Patch Set 7 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Patch Set 8 : diff -r e2a4b13871b6 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2042 lines) Patch
R pkg/present/args.go View 1 1 chunk +0 lines, -229 lines 0 comments Download
R pkg/present/code.go View 1 1 chunk +0 lines, -252 lines 0 comments Download
R pkg/present/doc.go View 1 1 chunk +0 lines, -184 lines 0 comments Download
A pkg/present/gone.go View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
R pkg/present/html.go View 1 1 chunk +0 lines, -31 lines 0 comments Download
R pkg/present/iframe.go View 1 1 chunk +0 lines, -45 lines 0 comments Download
R pkg/present/image.go View 1 1 chunk +0 lines, -45 lines 0 comments Download
R pkg/present/link.go View 1 1 chunk +0 lines, -88 lines 0 comments Download
R pkg/present/link_test.go View 1 1 chunk +0 lines, -40 lines 0 comments Download
R pkg/present/parse.go View 1 1 chunk +0 lines, -495 lines 0 comments Download
R pkg/present/style.go View 1 1 chunk +0 lines, -166 lines 0 comments Download
R pkg/present/style_test.go View 1 1 chunk +0 lines, -116 lines 0 comments Download
R pkg/socket/socket.go View 1 1 chunk +0 lines, -345 lines 0 comments Download
M present/appengine.go View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M present/dir.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M present/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M present/local.go View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
10 years, 7 months ago (2013-09-18 10:27:17 UTC) #1
dsymonds
LGTM On 18 Sep 2013 20:27, <adg@golang.org> wrote: > Reviewers: golang-dev1, > > Message: > ...
10 years, 7 months ago (2013-09-18 10:48:58 UTC) #2
adg
10 years, 7 months ago (2013-09-19 00:58:59 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=aaae64d69b11&repo=talks ***

go.talks/present: use present and socket packages from go.tools

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/13263054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b