code review 13263043: net: BUG section for ReadFrom, ReadFromIP methods of IP...

net: BUG section for ReadFrom, ReadFromIP methods of IPConn on "ip4" network

Fixes issue 3944.

[mikio, 2013-08-27 04:12:19]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2013-08-28 04:13:34]

ping

[r, 2013-08-28 10:57:08]

https://codereview.appspot.com/13263043/diff/5001/src/pkg/net/iprawsock_posix.go
File src/pkg/net/iprawsock_posix.go (right):

https://codereview.appspot.com/13263043/diff/5001/src/pkg/net/iprawsock_posix...
src/pkg/net/iprawsock_posix.go:18: // Read and ReadMsgIP can return a complete
packet. We can't change
I'm sorry but this is very hard to parse. I'm not quite sure what you're saying.

Let me write what I think you're saying, and you can correct me. I'll let you
reformat.


BUG(mikio): On every POSIX platform, reads from the "ip4" network using the
ReadFrom or ReadFromIP method might not return a complete IPv4 packet, including
its header, even if there is space available. This can occur even in cases where
Read or ReadMsgIP could return a complete packet. For this reason, it is
recommended that you do not uses these methods if it is important to receive a
full packet.

The Go 1 compatibliity guidelines make it impossible for us to change the
behavior of these methods; use Read or ReadMsgIP instead.

[mikio, 2013-08-29 01:22:11]

PTAL

On Wed, Aug 28, 2013 at 7:57 PM,  <r@golang.org> wrote:

> Let me write what I think you're saying, and you can correct me. I'll
> let you reformat.

Thank you very much.

[r, 2013-08-29 01:23:55]

LGTM

[mikio, 2013-08-29 01:25:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=4fd50a6beed3 ***

net: BUG section for ReadFrom, ReadFromIP methods of IPConn on "ip4" network

Fixes issue 3944.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13263043