Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(805)

Issue 1326042: code review 1326042: changes &x -> x[0:] for array to slice conversion (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by rsc
Modified:
14 years, 10 months ago
Reviewers:
CC:
gri, golang-dev
Visibility:
Public.

Description

changes &x -> x[0:] for array to slice conversion

Patch Set 1 #

Patch Set 2 : code review 1326042: changes &x -> x[0:] for array to slice conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -95 lines) Patch
M src/cmd/godoc/godoc.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/bytes/buffer.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/compress/flate/flate_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/compress/flate/huffman_bit_writer.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/compress/flate/inflate.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/compress/zlib/writer_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/block/ecb_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/crypto/block/xor_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/blowfish/block.go View 1 chunk +5 lines, -5 lines 0 comments Download
M src/pkg/crypto/blowfish/cipher.go View 1 chunk +5 lines, -5 lines 0 comments Download
M src/pkg/crypto/md4/md4.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/md5/md5.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/rand/rand.go View 2 chunks +7 lines, -7 lines 0 comments Download
M src/pkg/crypto/ripemd160/ripemd160.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/sha1/sha1.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/sha256/sha256.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/sha512/sha512.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/conn.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/debug/elf/file.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/encoding/ascii85/ascii85.go View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/encoding/base64/base64.go View 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/encoding/git85/git.go View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/exec/exec.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/format.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/print.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/scan.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/printer.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/fs.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/fd.go View 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/net/fd_darwin.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/net/fd_linux.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/ipsock.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/server_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/net/sock.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/timeout_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/os/dir_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/file.go View 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/os/os_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/os/sys_linux.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/patch/git.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/sort/sort_test.go View 1 6 chunks +9 lines, -9 lines 0 comments Download
M src/pkg/syscall/exec.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/syscall_linux.go View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/syslog/syslog_test.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/tabwriter/tabwriter.go View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/utf8/utf8_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
gri
LGTM
14 years, 10 months ago (2010-05-27 03:19:20 UTC) #1
rsc
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-05-27 21:51:43 UTC) #2
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=f358806ac42e *** changes &x -> x[0:] for array to slice conversion R=gri ...
14 years, 10 months ago (2010-05-27 21:51:54 UTC) #3
gri
14 years, 10 months ago (2010-05-27 22:50:05 UTC) #4
LGTM

On Thu, May 27, 2010 at 2:51 PM, <rsc@golang.org> wrote:

> Reviewers: gri,
>
> Message:
> Hello gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> changes &x -> x[0:] for array to slice conversion
>
> Please review this at http://codereview.appspot.com/1326042/show
>
> Affected files:
>  M src/cmd/godoc/godoc.go
>  M src/pkg/bytes/buffer.go
>  M src/pkg/compress/flate/flate_test.go
>  M src/pkg/compress/flate/huffman_bit_writer.go
>  M src/pkg/compress/flate/inflate.go
>  M src/pkg/compress/zlib/writer_test.go
>  M src/pkg/crypto/block/ecb_test.go
>  M src/pkg/crypto/block/xor_test.go
>  M src/pkg/crypto/blowfish/block.go
>  M src/pkg/crypto/blowfish/cipher.go
>  M src/pkg/crypto/md4/md4.go
>  M src/pkg/crypto/md5/md5.go
>  M src/pkg/crypto/rand/rand.go
>  M src/pkg/crypto/ripemd160/ripemd160.go
>  M src/pkg/crypto/sha1/sha1.go
>  M src/pkg/crypto/sha256/sha256.go
>  M src/pkg/crypto/sha512/sha512.go
>  M src/pkg/crypto/tls/conn.go
>  M src/pkg/debug/elf/file.go
>  M src/pkg/encoding/ascii85/ascii85.go
>  M src/pkg/encoding/base64/base64.go
>  M src/pkg/encoding/git85/git.go
>  M src/pkg/exec/exec.go
>  M src/pkg/fmt/format.go
>  M src/pkg/fmt/print.go
>  M src/pkg/fmt/scan.go
>  M src/pkg/go/printer/printer.go
>  M src/pkg/http/fs.go
>  M src/pkg/net/fd.go
>  M src/pkg/net/fd_darwin.go
>  M src/pkg/net/fd_linux.go
>  M src/pkg/net/ipsock.go
>  M src/pkg/net/server_test.go
>  M src/pkg/net/sock.go
>  M src/pkg/net/timeout_test.go
>  M src/pkg/os/dir_linux.go
>  M src/pkg/os/file.go
>  M src/pkg/os/os_test.go
>  M src/pkg/os/sys_linux.go
>  M src/pkg/patch/git.go
>  M src/pkg/sort/sort_test.go
>  M src/pkg/syscall/exec.go
>  M src/pkg/syscall/syscall_linux.go
>  M src/pkg/syslog/syslog_test.go
>  M src/pkg/tabwriter/tabwriter.go
>  M src/pkg/utf8/utf8_test.go
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b