Issue 13253049: code review 13253049: cmd/go: use pattern to prune file tree walk

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13253049: code review 13253049: cmd/go: use pattern to prune file tree walk (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

cmd/go: use pattern to prune file tree walk For example, if the pattern is m... there is no need to look in directories not beginning with m. Fixes issue 5214.

Patch Set 1 #

Patch Set 2 : diff -r 22365bd87858 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 22365bd87858 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 7e10c412efea https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -9 lines)			Patch
M	src/cmd/go/main.go	View	1 2 3	4 chunks	+39 lines, -0 lines	0 comments	Download
M	src/cmd/go/match_test.go	View	1	2 chunks	+61 lines, -9 lines	0 comments	Download
M	src/cmd/go/test.bash	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
A	src/cmd/go/testdata/src/badpkg/x.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-10 20:19:15 UTC) #1

rsc

11 years, 6 months ago (2013-09-11 13:57:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e176e9d59540 ***

cmd/go: use pattern to prune file tree walk

For example, if the pattern is m... there is
no need to look in directories not beginning with m.

Fixes issue 5214.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/13253049

Expand All Messages | Collapse All Messages