Issue 13253048: code review 13253048: cmd/go: fix build -n output when using swig

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13253048: code review 13253048: cmd/go: fix build -n output when using swig (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/go: fix build -n output when using swig $INTBITS will not be defined, of course, but that's the best we can do. Fixes issue 5978.

Patch Set 1 #

Patch Set 2 : diff -r 4131b84341bc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 196ea3c6e953 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 196ea3c6e953 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/cmd/go/build.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-09-10 16:48:06 UTC) #1

rsc

11 years, 6 months ago (2013-09-10 16:55:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2d66e8642dc0 ***

cmd/go: fix build -n output when using swig

$INTBITS will not be defined, of course, but that's the best we can do.

Fixes issue 5978.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/13253048

Expand All Messages | Collapse All Messages