Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1272)

Issue 13250047: code review 13250047: cmd/go: implement -x correctly for 'go vet', 'go fmt', ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by rsc
Modified:
11 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

cmd/go: implement -x correctly for 'go vet', 'go fmt', and so on Fixes issue 5676.

Patch Set 1 #

Patch Set 2 : diff -r 677a33edec74 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 52c38a597fb0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0e4e942470f7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/go/main.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2013-09-10 16:24:28 UTC) #1
bradfitz
LGTM On Sep 10, 2013 9:24 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev1, > > Message: ...
11 years, 6 months ago (2013-09-10 16:28:40 UTC) #2
rsc
11 years, 6 months ago (2013-09-10 16:47:55 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=196ea3c6e953 ***

cmd/go: implement -x correctly for 'go vet', 'go fmt', and so on

Fixes issue 5676.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13250047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b