code review 13241046: net: add addrList

net: add addrList

This CL adds a new type addrList that will carry a short list of IP
addresses to dial helper functions in the upcoming CLs.

This is in preparation for TCP connection setup with fast failover on
dual IP stack node as described in RFC 6555.

Update issue 3610
Update issue 5267

[mikio, 2013-08-30 00:15:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-30 00:26:25]

LGTM



On Thu, Aug 29, 2013 at 5:15 PM, <mikioh.mikioh@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: add addrList
>
> This CL adds a new type addrList that will carry a short list of IP
> addresses to dial helper functions in the upcoming CLs.
>
> This is in preparation for TCP connection setup with fast failover on
> dual IP stack node as described in RFC 6555.
>
> Update issue 3610
> Update issue 5267
>
> Please review this at
https://codereview.appspot.**com/13241046/<https://codereview.appspot.com/132...
>
> Affected files:
>   M src/pkg/net/ipsock.go
>
>
> Index: src/pkg/net/ipsock.go
> ==============================**==============================**=======
> --- a/src/pkg/net/ipsock.go
> +++ b/src/pkg/net/ipsock.go
> @@ -40,6 +40,24 @@
>         toAddr() Addr
>  }
>
> +// An addrList represents a list of network endpoint addresses.
> +type addrList []netaddr
> +
> +func (al addrList) toAddr() Addr {
> +       switch len(al) {
> +       case 0:
> +               return nil
> +       case 1:
> +               return al[0].toAddr()
> +       default:
> +               // For now, we'll roughly pick first one without
> +               // considering dealing with any preferences such as
> +               // DNS TTL, transport path quality, network routing
> +               // information.
> +               return al[0].toAddr()
> +       }
> +}
> +
>  var errNoSuitableAddress = errors.New("no suitable address found")
>
>  // firstFavoriteAddr returns an address that implemets netaddr
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[mikio, 2013-08-30 00:28:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=6939fe74ea98 ***

net: add addrList

This CL adds a new type addrList that will carry a short list of IP
addresses to dial helper functions in the upcoming CLs.

This is in preparation for TCP connection setup with fast failover on
dual IP stack node as described in RFC 6555.

Update issue 3610
Update issue 5267

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/13241046