Issue 13239052: code review 13239052: runtime: make ARM integer div-by-zero traceback-friendly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13239052: code review 13239052: runtime: make ARM integer div-by-zero traceback-friendly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
minux1

CC:
golang-dev, minux1

Visibility:
Public.

Description

runtime: make ARM integer div-by-zero traceback-friendly The implementation of division in the 5 toolchain is a bit too magical. Hide the magic from the traceback routines. Also add a test for the results of the software divide routine. Fixes issue 5805.

Patch Set 1 #

Patch Set 2 : diff -r 565e2d46bb68 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 565e2d46bb68 https://code.google.com/p/go/ #

Patch Set 4 : diff -r a6d1a3f0411a https://code.google.com/p/go #

Patch Set 5 : diff -r 94272206b0cb https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+487 lines, -18 lines)			Patch
	M	src/pkg/runtime/vlop_arm.s	View	1 2 3	3 chunks	+27 lines, -18 lines	0 comments	Download
	A	test/divmod.go	View	1 2 3	1 chunk	+460 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-09-15 01:49:57 UTC) #1

minux1

LGTM. the divmod routine should have been written this way.

11 years, 6 months ago (2013-09-16 03:47:48 UTC) #2

minux1

the long test passed on nexus4. .... 268435456 ... 536870912 ... 1073741824 ... 2147483648 ...

11 years, 6 months ago (2013-09-16 06:00:43 UTC) #3

rsc

11 years, 6 months ago (2013-09-16 18:04:48 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a6fc26ebfd61 ***

runtime: make ARM integer div-by-zero traceback-friendly

The implementation of division in the 5 toolchain is a bit too magical.
Hide the magic from the traceback routines.

Also add a test for the results of the software divide routine.

Fixes issue 5805.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/13239052

Expand All Messages | Collapse All Messages