code review 132150043: io: document that Readers and Writers must not retain b...

io: document that Readers and Writers must not retain buffers

There are both many callers and many implementations of these
interfaces, so make the contract explicit. Callers generally
assume this, and at least the standard library and other
implementations obey this, but it's never stated explicitly,
making it somewhat risky to assume.

[bradfitz, 2014-08-25 23:09:13]

Hello golang-codereviews@googlegroups.com (cc: gri@golang.org, r@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2014-08-25 23:31:46]

LGTM

but wait for rsc

[rsc, 2014-08-26 04:30:24]

LGTM

[bradfitz, 2014-08-26 04:38:34]

*** Submitted as https://code.google.com/p/go/source/detail?r=bfbcddc8da9f ***

io: document that Readers and Writers must not retain buffers

There are both many callers and many implementations of these
interfaces, so make the contract explicit. Callers generally
assume this, and at least the standard library and other
implementations obey this, but it's never stated explicitly,
making it somewhat risky to assume.

LGTM=gri, rsc
R=golang-codereviews, gri
CC=golang-codereviews, r, rsc
https://codereview.appspot.com/132150043

[gobot, 2014-08-26 04:52:51]

This CL appears to have broken the darwin-amd64 builder.
See http://build.golang.org/log/e920a979f38b0bc9c836385f3877fe428ae24a08