Issue 131980043: code review 131980043: runtime: convert memclrBytes to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131980043: code review 131980043: runtime: convert memclrBytes to Go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by josharian

Modified:
10 years, 6 months ago

Reviewers:
khr

CC:
khr, golang-codereviews

Visibility:
Public.

Patch Set 2 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://code.google.com/p/go #

Patch Set 3 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://code.google.com/p/go #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
M	src/pkg/runtime/alg.go	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/alg.goc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/pkg/runtime/export_test.go	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

josharian

Hello khr@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 6 months ago (2014-08-20 20:02:48 UTC) #1

khr

LGTM. https://codereview.appspot.com/131980043/diff/40001/src/pkg/runtime/alg.go File src/pkg/runtime/alg.go (right): https://codereview.appspot.com/131980043/diff/40001/src/pkg/runtime/alg.go#newcode279 src/pkg/runtime/alg.go:279: s := *(*sliceStruct)(unsafe.Pointer(&b)) You don't need the leading ...

10 years, 6 months ago (2014-08-20 20:37:44 UTC) #2

josharian

10 years, 6 months ago (2014-08-20 21:02:18 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a457912af7d0 ***

runtime: convert memclrBytes to Go

LGTM=khr
R=khr
CC=golang-codereviews
https://codereview.appspot.com/131980043

Expand All Messages | Collapse All Messages