code review 131900044: net/http: correct error message for incorrect Body length

net/http: correct error message for incorrect Body length

Fixes issue 8140.

[esk, 2014-08-19 02:51:41]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-08-19 03:40:08]

LGTM

thanks!



On Mon, Aug 18, 2014 at 7:51 PM, evankroske via golang-codereviews <
golang-codereviews@googlegroups.com> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/http: correct error message for incorrect Body length
>
> Fixes issue 8140.
>
> Please review this at https://codereview.appspot.com/131900044/
>
> Affected files (+3, -3 lines):
>   M src/pkg/net/http/requestwrite_test.go
>   M src/pkg/net/http/transfer.go
>
>
> Index: src/pkg/net/http/requestwrite_test.go
> ===================================================================
> --- a/src/pkg/net/http/requestwrite_test.go
> +++ b/src/pkg/net/http/requestwrite_test.go
> @@ -280,7 +280,7 @@
>                         ContentLength: 10, // but we're going to send only
> 5 bytes
>                 },
>                 Body:      []byte("12345"),
> -               WantError: errors.New("http: Request.ContentLength=10 with
> Body length 5"),
> +               WantError: errors.New("http: ContentLength=10 with Body
> length 5"),
>         },
>
>         // Request with a ContentLength of 4 but an 8 byte body.
> @@ -294,7 +294,7 @@
>                         ContentLength: 4, // but we're going to try to
> send 8 bytes
>                 },
>                 Body:      []byte("12345678"),
> -               WantError: errors.New("http: Request.ContentLength=4 with
> Body length 8"),
> +               WantError: errors.New("http: ContentLength=4 with Body
> length 8"),
>         },
>
>         // Request with a 5 ContentLength and nil body.
> Index: src/pkg/net/http/transfer.go
> ===================================================================
> --- a/src/pkg/net/http/transfer.go
> +++ b/src/pkg/net/http/transfer.go
> @@ -228,7 +228,7 @@
>         }
>
>         if !t.ResponseToHEAD && t.ContentLength != -1 && t.ContentLength
> != ncopy {
> -               return fmt.Errorf("http: Request.ContentLength=%d with
> Body length %d",
> +               return fmt.Errorf("http: ContentLength=%d with Body length
> %d",
>                         t.ContentLength, ncopy)
>         }
>
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[bradfitz, 2014-08-19 03:40:20]

*** Submitted as https://code.google.com/p/go/source/detail?r=8f918b7db01b ***

net/http: correct error message for incorrect Body length

Fixes issue 8140.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/131900044

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[esk, 2014-08-28 03:58:12]

*** Abandoned ***