Issue 13184043: code review 13184043: net: enable PacketConn test for raw IP network on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13184043: code review 13184043: net: enable PacketConn test for raw IP network on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by mikio

Modified:
10 years, 7 months ago

Reviewers:
brainman

CC:
brainman, golang-dev

Visibility:
Public.

Description

net: enable PacketConn test for raw IP network on Windows Just forgot to include this in CL 12843043. Also consolidates the code dealing with test environment. Update issue 6122

Patch Set 1 : diff -r eb5bdb19aa21 https://code.google.com/p/go #

Patch Set 2 : diff -r 3c1174dcac91 https://code.google.com/p/go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -59 lines)			Patch
	M	src/pkg/net/packetconn_test.go	View		3 chunks	+53 lines, -59 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 8 months ago (2013-08-23 23:24:18 UTC) #1

mikio

10 years, 8 months ago (2013-08-27 03:18:05 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7f821344f21f ***

net: enable PacketConn test for raw IP network on Windows

Just forgot to include this in CL 12843043.
Also consolidates the code dealing with test environment.

Update issue 6122

R=alex.brainman
CC=golang-dev
https://codereview.appspot.com/13184043

Expand All Messages | Collapse All Messages