Issue 131030044: code review 131030044: cmd/gofmt: remove testdata/*.gofmt files

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 131030044: code review 131030044: cmd/gofmt: remove testdata/*.gofmt files (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gri

Modified:
10 years, 6 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

cmd/gofmt: remove testdata/*.gofmt files This files were added accidentally and are not required for running the tests (they are produced by failing tests for easier debugging).

Patch Set 1 #

Patch Set 2 : diff -r 9985ecf9828f87d8887550109060357e2163ab8a https://code.google.com/p/go/ #

Patch Set 3 : diff -r d06e79685295c5e0da29106e139cfaafb3318258 https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -47 lines)			Patch
R	src/cmd/gofmt/testdata/stdin1.golden.gofmt	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin1.input.gofmt	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin2.golden.gofmt	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin2.input.gofmt	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin3.golden.gofmt	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin3.input.gofmt	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin4.golden.gofmt	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
R	src/cmd/gofmt/testdata/stdin4.input.gofmt	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2014-08-21 21:54:27 UTC) #2

gri

10 years, 6 months ago (2014-08-21 21:54:35 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=79cbd2059d28 ***

cmd/gofmt: remove testdata/*.gofmt files

This files were added accidentally and are
not required for running the tests (they
are produced by failing tests for easier
debugging).

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/131030044

Expand All Messages | Collapse All Messages