code review 130990043: runtime: init GC later

runtime: init GC later
Init GC later as it needs to read GOGC env var.
Fixes issue 8562.

[dvyukov, 2014-08-20 11:41:41]

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rlh@golang.org,
rsc@golang.org),

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[DMorsing, 2014-08-20 13:57:22]

https://codereview.appspot.com/130990043/diff/20002/src/pkg/runtime/env_posix.c
File src/pkg/runtime/env_posix.c (right):

https://codereview.appspot.com/130990043/diff/20002/src/pkg/runtime/env_posix...
src/pkg/runtime/env_posix.c:25: if(envv == nil && runtime·strcmp((byte*)s,
(byte*)"GOTRACEBACK") != 0)
I really don't like this exception. Is it really needed?

[dvyukov, 2014-08-20 14:04:08]

https://codereview.appspot.com/130990043/diff/20002/src/pkg/runtime/env_posix.c
File src/pkg/runtime/env_posix.c (right):

https://codereview.appspot.com/130990043/diff/20002/src/pkg/runtime/env_posix...
src/pkg/runtime/env_posix.c:25: if(envv == nil && runtime·strcmp((byte*)s,
(byte*)"GOTRACEBACK") != 0)
On 2014/08/20 13:57:21, DMorsing wrote:
> I really don't like this exception. Is it really needed?

GOTRACEBACK is queried during the very first mallocs, which call profilealloc
which call gentraceback

[DMorsing, 2014-08-20 14:29:29]

On 2014/08/20 14:04:08, dvyukov wrote:
> GOTRACEBACK is queried during the very first mallocs, which call profilealloc
> which call gentraceback

Why not just init traceback_cache to 4 and get rid of the early call to
gotraceback?

[DMorsing, 2014-08-20 14:47:30]

On 2014/08/20 14:29:29, DMorsing wrote:
> On 2014/08/20 14:04:08, dvyukov wrote:
> > GOTRACEBACK is queried during the very first mallocs, which call
profilealloc
> > which call gentraceback
> 
> Why not just init traceback_cache to 4 and get rid of the early call to
> gotraceback?

Sorry, meant 2

[dvyukov, 2014-08-20 14:50:07]

PTAL

[DMorsing, 2014-08-20 15:01:16]

LGTM

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/proc.c#ne...
src/pkg/runtime/proc.c:172: runtime·gotraceback(nil);
This is no longer needed.

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c
File src/pkg/runtime/runtime.c (right):

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c...
src/pkg/runtime/runtime.c:122: traceback_cache = ~(uint32)0;
Not needed anymore

[rsc, 2014-08-20 18:15:08]

LGTM

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c
File src/pkg/runtime/runtime.c (right):

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c...
src/pkg/runtime/runtime.c:122: traceback_cache = ~(uint32)0;
On 2014/08/20 15:01:16, DMorsing wrote:
> Not needed anymore

Not only is it not needed, it's incorrect. Please delete.

[dvyukov, 2014-08-21 07:50:49]

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/proc.c
File src/pkg/runtime/proc.c (right):

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/proc.c#ne...
src/pkg/runtime/proc.c:172: runtime·gotraceback(nil);
On 2014/08/20 15:01:16, DMorsing wrote:
> This is no longer needed.

Done.

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c
File src/pkg/runtime/runtime.c (right):

https://codereview.appspot.com/130990043/diff/40001/src/pkg/runtime/runtime.c...
src/pkg/runtime/runtime.c:122: traceback_cache = ~(uint32)0;
On 2014/08/20 18:15:08, rsc wrote:
> On 2014/08/20 15:01:16, DMorsing wrote:
> > Not needed anymore
> 
> Not only is it not needed, it's incorrect. Please delete.

Done.

[dvyukov, 2014-08-21 07:55:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=400ada19db6a ***

runtime: init GC later
Init GC later as it needs to read GOGC env var.
Fixes issue 8562.

LGTM=daniel.morsing, rsc
R=golang-codereviews, daniel.morsing, rsc
CC=golang-codereviews, khr, rlh
https://codereview.appspot.com/130990043

[gobot, 2014-08-21 08:36:51]

This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/5e215715428411456600710e34626d543ddd4c95