Issue 13094048: code review 13094048: go.talks/2012/simple: fix bug on test code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13094048: code review 13094048: go.talks/2012/simple: fix bug on test code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by francesc

Modified:
10 years, 8 months ago

Reviewers:
r

CC:
adg, r, golang-dev

Visibility:
Public.

Description

go.talks/2012/simple: fix bug on test code.

Patch Set 1 #

Patch Set 2 : diff -r f3ece4b38f43 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r f3ece4b38f43 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r f3ece4b38f43 https://code.google.com/p/go.talks #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	2012/simple/test.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

francesc

Hello adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

10 years, 8 months ago (2013-08-22 23:10:48 UTC) #1

francesc

It was actually a bug. The 'got != want' didn't compile, since want was not ...

10 years, 8 months ago (2013-08-22 23:38:40 UTC) #3

francesc

*** Submitted as https://code.google.com/p/go/source/detail?r=efaf45068c15&repo=talks *** go.talks/2012/simple: fix bug on test code. R=adg, r CC=golang-dev https://codereview.appspot.com/13094048

10 years, 8 months ago (2013-08-22 23:47:29 UTC) #4

Yeah, there is that.

Expand All Messages | Collapse All Messages