code review 130920043: time: removed from tests now obsolete assumption about ...

time: removed from tests now obsolete assumption about Australian tz abbreviations

Australian timezones abbreviation for standard and daylight saving time were recently
changed from EST for both to AEST and AEDT in the icann tz database (see changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation function
understand that Feb EST and Aug EST are different time zones, even though they are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2) has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations, two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes issue 8547.

[alb, 2014-08-19 21:32:13]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-08-20 01:48:16]

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test.go
File src/pkg/time/format_test.go (right):

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test....
src/pkg/time/format_test.go:186: func TestParseAST(t *testing.T) {
TestParseInLocation -- that's what it's actually testing anyway

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test....
src/pkg/time/format_test.go:209: loc, err = LoadLocation("America/Blanc-Sablon")
don't re-use loc.  don't even use loc up above, actually. name these "baghdad"
and "eastCanada" or "blancSablon" perhaps?

[alb, 2014-08-20 12:56:31]

Renamed test name and location variables

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test.go
File src/pkg/time/format_test.go (right):

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test....
src/pkg/time/format_test.go:186: func TestParseAST(t *testing.T) {
On 2014/08/20 01:48:16, bradfitz wrote:
> TestParseInLocation -- that's what it's actually testing anyway

Done.

https://codereview.appspot.com/130920043/diff/40001/src/pkg/time/format_test....
src/pkg/time/format_test.go:209: loc, err = LoadLocation("America/Blanc-Sablon")
On 2014/08/20 01:48:16, bradfitz wrote:
> don't re-use loc.  don't even use loc up above, actually. name these "baghdad"
> and "eastCanada" or "blancSablon" perhaps?

Done.

[bradfitz, 2014-08-21 17:35:37]

LGTM

[bradfitz, 2014-08-21 17:35:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=7dba9475ee72 ***

time: removed from tests now obsolete assumption about Australian tz
abbreviations

Australian timezones abbreviation for standard and daylight saving time were
recently
changed from EST for both to AEST and AEDT in the icann tz database (see
changelog
on www.iana.org/time-zones).

A test in the time package was written to check that the ParseInLocation
function
understand that Feb EST and Aug EST are different time zones, even though they
are
both called EST. This is no longer the case, and the Date function now returns
AEST or AEDT for australian tz on every Linux system with an up to date tz
database
(and this makes the test fail).

Since I wasn't able to find another country that 1) uses daylight saving and 2)
has
the same abbreviation for both on tzdata, I changed the test to make sure that
ParseInLocation does not get confused when it parses, in different locations,
two
dates with the same abbreviation (this was suggested in the mailing list).

Fixes issue 8547.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/130920043

Committer: Brad Fitzpatrick <bradfitz@golang.org>