Issue 13084043: code review 13084043: cmd/5g, cmd/6g, cmd/8g: faster compilation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13084043: code review 13084043: cmd/5g, cmd/6g, cmd/8g: faster compilation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dvyukov

Modified:
11 years, 7 months ago

Reviewers:
r

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/5g, cmd/6g, cmd/8g: faster compilation Replace linked list walk with memset. This reduces CPU time taken by 'go install -a std' by ~10%. Before: real user sys 0m23.561s 0m16.625s 0m5.848s 0m23.766s 0m16.624s 0m5.846s 0m23.742s 0m16.621s 0m5.868s after: 0m22.714s 0m14.858s 0m6.138s 0m22.644s 0m14.875s 0m6.120s 0m22.604s 0m14.854s 0m6.081s

Patch Set 1 #

Patch Set 2 : diff -r 6d2a2628859d https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 4fa24b4ac2f9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 4fa24b4ac2f9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 4fa24b4ac2f9 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 5600ebc3b0b1 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -16 lines)			Patch
M	src/cmd/5g/peep.c	View	1 2 3	4 chunks	+12 lines, -5 lines	0 comments	Download
M	src/cmd/6g/peep.c	View	1 2	6 chunks	+13 lines, -6 lines	0 comments	Download
M	src/cmd/8g/peep.c	View	1 2 3	4 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 7 months ago (2013-08-20 20:12:52 UTC) #1

dvyukov

11 years, 7 months ago (2013-08-21 10:20:42 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ef4ee02a5853 ***

cmd/5g, cmd/6g, cmd/8g: faster compilation
Replace linked list walk with memset.
This reduces CPU time taken by 'go install -a std' by ~10%.
Before:
real		user		sys
0m23.561s	0m16.625s	0m5.848s
0m23.766s	0m16.624s	0m5.846s
0m23.742s	0m16.621s	0m5.868s
after:
0m22.714s	0m14.858s	0m6.138s
0m22.644s	0m14.875s	0m6.120s
0m22.604s	0m14.854s	0m6.081s

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/13084043

Expand All Messages | Collapse All Messages