Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 130550043: code review 130550043: go.blog/constants: use a format with Printf (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by r
Modified:
9 years, 8 months ago
Reviewers:
adg
CC:
adg, golang-codereviews
Visibility:
Public.

Description

go.blog/constants: use a format with Printf Otherwise the prose around this snippet is confusing.

Patch Set 1 #

Patch Set 2 : diff -r 1758d8bdae21c854d846c3dd96d2c0dc9a7d9ffd https://code.google.com/p/go.blog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/constants/default1.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
r
Hello adg (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.blog
9 years, 8 months ago (2014-08-26 01:24:22 UTC) #1
adg
LGTM
9 years, 8 months ago (2014-08-26 01:26:13 UTC) #2
r
9 years, 8 months ago (2014-08-26 01:26:28 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=cff98903c99b&repo=blog ***

go.blog/constants: use a format with Printf
Otherwise the prose around this snippet is confusing.

LGTM=adg
R=adg
CC=golang-codereviews
https://codereview.appspot.com/130550043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b