LGTM On Tuesday, 26 August 2014, <r@golang.org> wrote: > Reviewers: adg, > > Message: > ...
9 years, 8 months ago
(2014-08-26 00:55:20 UTC)
#2
LGTM
On Tuesday, 26 August 2014, <r@golang.org> wrote:
> Reviewers: adg,
>
> Message:
> Hello adg (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.blog
>
>
> Description:
> go.blog: more glitches in constants post
> All inconsequential.
>
> Please review this at https://codereview.appspot.com/130540043/
>
> Affected files (+3, -3 lines):
> M content/constants.article
>
>
> Index: content/constants.article
> ===================================================================
> --- a/content/constants.article
> +++ b/content/constants.article
> @@ -16,7 +16,7 @@
>
> In the early days of thinking about Go, we talked about a number of
> problems caused by the way C and its descendants let you mix and match
> numeric types.
> Many mysterious bugs, crashes, and portability problems are caused by
> expressions that combine integers of different sizes and "signedness".
> -Although to a seasoned C programmer, the result of a calculation like
> +Although to a seasoned C programmer the result of a calculation like
>
> unsigned int u = 1e9;
> long signed int i = -1;
> @@ -172,7 +172,7 @@
> to pass as an argument, and the concrete type stored for that argument is
> the default type of the constant.
> This process is analogous to what we saw earlier when declaring an
> initialized value using an untyped string constant.
>
> -You can see the result in this example, which uses the format '%v' to
> print the value and `%T` to print the type of the value being passed to
> `fmt.Printf`:
> +You can see the result in this example, which uses the format `%v` to
> print the value and `%T` to print the type of the value being passed to
> `fmt.Printf`:
>
> .play -edit constants/default2.go /START/,/STOP/
>
> @@ -423,7 +423,7 @@
>
> .play -edit constants/numbers1.go /START/,/STOP/
>
> -The output from this snippet is: `1 1 1 1 1 (1+0i) 1`.
> +The output from this snippet is: `1`1`1`1`1`(1+0i)`1`.
>
> You can even do nutty stuff like
>
>
>
>
*** Submitted as https://code.google.com/p/go/source/detail?r=1758d8bdae21&repo=blog *** go.blog: more glitches in constants post All inconsequential. LGTM=adg R=adg ...
9 years, 8 months ago
(2014-08-26 00:55:50 UTC)
#3
Issue 130540043: code review 130540043: go.blog: more glitches in constants post
(Closed)
Created 9 years, 8 months ago by r
Modified 9 years, 8 months ago
Reviewers:
Base URL:
Comments: 0