Issue 130090043: code review 130090043: fmt: fix size returned on fast path of ReadRune

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 130090043: code review 130090043: fmt: fix size returned on fast path of ReadRune (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 8 months ago by r

Modified:
9 years, 8 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

fmt: fix size returned on fast path of ReadRune Fixes issue 8512.

Patch Set 1 #

Patch Set 2 : diff -r ff34a3e84dc0b99eaf080eb19decc1f0a1f615a0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 88dc2cecad6ba572cf063170e0d94b8291af4a7f https://code.google.com/p/go/ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	src/pkg/fmt/scan.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/pkg/fmt/scan_test.go	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

9 years, 8 months ago (2014-08-15 16:49:34 UTC) #1

9 years, 8 months ago (2014-08-15 18:41:15 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=db1c196c7e1b ***

fmt: fix size returned on fast path of ReadRune
Fixes issue 8512.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/130090043

Expand All Messages | Collapse All Messages