Issue 13002044: code review 13002044: time: fix time zones yet again.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13002044: code review 13002044: time: fix time zones yet again. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by r

Modified:
10 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

time: fix time zones yet again. This time we're going for 5! http://goo.gl/3ETYH7 Fixes issue 3790 Yeah, right.

Patch Set 2 : diff -r ffd84f0d7960 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f6ab40335287 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 49ef6e25dabe https://code.google.com/p/go/ #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -12 lines)			Patch
M	src/pkg/time/export_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/pkg/time/format.go	View	1 2 3	2 chunks	+27 lines, -12 lines	0 comments	Download
M	src/pkg/time/time_test.go	View	1 2	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 9 months ago (2013-08-16 00:58:23 UTC) #1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 9 months ago (2013-08-16 04:51:04 UTC) #2

adg

LGTM https://codereview.appspot.com/13002044/diff/2/src/pkg/time/format.go File src/pkg/time/format.go (right): https://codereview.appspot.com/13002044/diff/2/src/pkg/time/format.go#newcode1053 src/pkg/time/format.go:1053: if c < 'A' || 'Z' < c ...

10 years, 9 months ago (2013-08-16 04:54:12 UTC) #3

10 years, 9 months ago (2013-08-16 04:57:58 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=e6e61c41a2c0 ***

time: fix time zones yet again.
This time we're going for 5!
http://goo.gl/3ETYH7

Fixes issue 3790
Yeah, right.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/13002044

Expand All Messages | Collapse All Messages