Issue 12976043: code review 12976043: go-tour: add missing sandbox.go file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12976043: code review 12976043: go-tour: add missing sandbox.go file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 9 months ago by adg

Modified:
10 years, 9 months ago

Reviewers:
dsymonds, kortschak

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

go-tour: add missing sandbox.go file

Patch Set 1 #

Patch Set 2 : diff -r 3f353c59248f https://code.google.com/p/go-tour #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	A	prog/sandbox.go	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour

10 years, 9 months ago (2013-08-15 05:09:29 UTC) #1

adg

*** Submitted as https://code.google.com/p/go-tour/source/detail?r=90759b972266 *** go-tour: add missing sandbox.go file R=golang-dev, dsymonds CC=golang-dev https://codereview.appspot.com/12976043

10 years, 9 months ago (2013-08-15 05:39:27 UTC) #3

kortschak

Did you want sandbox.go to be displayed with the Go Local page? On Thu, 2013-08-15 ...

10 years, 9 months ago (2013-08-15 05:45:50 UTC) #4

adg

No https://codereview.appspot.com/12977043 On 15 August 2013 15:45, Dan Kortschak <dan.kortschak@adelaide.edu.au>wrote: > Did you want sandbox.go ...

10 years, 9 months ago (2013-08-15 05:48:42 UTC) #5

kortschak

Sorry. LGTM On Thu, 2013-08-15 at 15:48 +1000, Andrew Gerrand wrote: > No https://codereview.appspot.com/12977043

10 years, 9 months ago (2013-08-15 05:50:39 UTC) #6

adg

10 years, 9 months ago (2013-08-15 05:52:09 UTC) #7

On 15 August 2013 15:50, Dan Kortschak <dan.kortschak@adelaide.edu.au>wrote:

> Sorry.


Why apologize? It's my carelessness you're correcting. Thanks!

Expand All Messages | Collapse All Messages