Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1260)

Issue 129760043: code review 129760043: [release-branch.go1.3] cmd/8g: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
gobot, minux
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

[release-branch.go1.3] cmd/8g: fix build ««« CL 129720043 / 0449858880be cmd/8g: fix build Fixes issue 8510. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/129720043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 17d80550d37198e6b1026a2c7aaaffb76f4eb51c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/8g/peep.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
adg
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2014-08-12 05:51:40 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=5794f7185ba0 *** [release-branch.go1.3] cmd/8g: fix build ««« CL 129720043 / 0449858880be cmd/8g: ...
9 years, 8 months ago (2014-08-12 05:51:59 UTC) #2
gobot
This CL appears to have broken the netbsd-386-minux builder. See http://build.golang.org/log/1fc937a66ae6816fbf760958be02c23a20754e1a
9 years, 8 months ago (2014-08-12 05:59:43 UTC) #3
minux
On Tue, Aug 12, 2014 at 1:59 AM, <gobot@golang.org> wrote: > This CL appears to ...
9 years, 8 months ago (2014-08-12 06:41:05 UTC) #4
minux
9 years, 8 months ago (2014-08-12 06:41:15 UTC) #5
btw, LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b