Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1311)

Issue 129720043: code review 129720043: cmd/8g: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by minux
Modified:
9 years, 7 months ago
Reviewers:
gobot, rsc, dfc
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

cmd/8g: fix build Fixes issue 8510.

Patch Set 1 #

Patch Set 2 : diff -r 8e5ec6948793f8c178a9604e543644afaf8a4965 https://code.google.com/p/go #

Patch Set 3 : diff -r 8e5ec6948793f8c178a9604e543644afaf8a4965 https://code.google.com/p/go #

Patch Set 4 : diff -r 37899cfe176cb3488378101da0faeed74124d1d3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/8g/peep.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
minux
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2014-08-11 20:21:31 UTC) #1
rsc
LGTM
9 years, 7 months ago (2014-08-11 21:11:12 UTC) #2
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=0449858880be *** cmd/8g: fix build Fixes issue 8510. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/129720043
9 years, 7 months ago (2014-08-11 21:11:34 UTC) #3
gobot
This CL appears to have broken the freebsd-amd64-race builder. See http://build.golang.org/log/aedd7768cd5d0fc4e623e103cb061e86533ba6c9
9 years, 7 months ago (2014-08-11 22:00:50 UTC) #4
dfc
9 years, 7 months ago (2014-08-11 22:04:20 UTC) #5
This is a real failure, but unrelated to this commit,
https://code.google.com/p/go/issues/detail?id=8483

On Tue, Aug 12, 2014 at 8:00 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the freebsd-amd64-race builder.
> See http://build.golang.org/log/aedd7768cd5d0fc4e623e103cb061e86533ba6c9
>
>
> https://codereview.appspot.com/129720043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b