code review 12970043: cmd/gc: &x panics if x does

cmd/gc: &x panics if x does

See golang.org/s/go12nil.

This CL is about getting all the right checks inserted.
A followup CL will add an optimization pass to
remove redundant checks.

[rsc, 2013-08-15 18:38:30]

Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-08-15 18:39:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=749d02164043 ***

cmd/gc: &x panics if x does

See golang.org/s/go12nil.

This CL is about getting all the right checks inserted.
A followup CL will add an optimization pass to
remove redundant checks.

R=ken2
CC=golang-dev
https://codereview.appspot.com/12970043

[dvyukov, 2013-08-15 19:06:16]

Probabaly it's caused by this:
$ go test -race -c pkg/runtime/race/testdata/mop_test.go
pkg/runtime/race/testdata/mop_test.go:1440: internal compiler error: naddr:
ONAME class i 130


On Thu, Aug 15, 2013 at 10:39 PM, <rsc@golang.org> wrote:

> *** Submitted as
>
https://code.google.com/p/go/**source/detail?r=749d02164043<https://code.goog...
>
>
> cmd/gc: &x panics if x does
>
> See golang.org/s/go12nil.
>
> This CL is about getting all the right checks inserted.
> A followup CL will add an optimization pass to
> remove redundant checks.
>
> R=ken2
> CC=golang-dev
>
https://codereview.appspot.**com/12970043<https://codereview.appspot.com/1297...
>
>
>
https://codereview.appspot.**com/12970043/<https://codereview.appspot.com/129...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-08-16 00:42:30]

On Thu, Aug 15, 2013 at 3:05 PM, Dmitry Vyukov <dvyukov@google.com> wrote:

> Probabaly it's caused by this:
> $ go test -race -c pkg/runtime/race/testdata/mop_test.go
> pkg/runtime/race/testdata/mop_test.go:1440: internal compiler error:
> naddr: ONAME class i 130
>

Fix on the way.

Russ