Issue 12960046: code review 12960046: net: have separate read and write processing threads on...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 12960046: code review 12960046: net: have separate read and write processing threads on... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by brainman

Modified:
10 years, 7 months ago

Reviewers:
mikio

CC:
golang-dev, mikio

Visibility:
Public.

Description

net: have separate read and write processing threads on windows Fixes issue 4195

Patch Set 1 #

Patch Set 2 : diff -r bb2db1e233b2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bb2db1e233b2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c3bf615ba223 https://go.googlecode.com/hg/ #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -21 lines)			Patch
M	src/pkg/net/fd_plan9.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/net/fd_unix.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/net/fd_windows.go	View	1	7 chunks	+16 lines, -12 lines	0 comments	Download
M	src/pkg/net/http/transport_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/sendfile_windows.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/timeout_test.go	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 7 months ago (2013-08-26 04:27:14 UTC) #1

brainman

10 years, 7 months ago (2013-08-27 04:54:05 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2f13cc5d7043 ***

net: have separate read and write processing threads on windows

Fixes issue 4195

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/12960046

Expand All Messages | Collapse All Messages